Fix ExtEventLoop to keep track of stream resources (refcount)#123
Merged
jsor merged 2 commits intoreactphp:masterfrom Dec 1, 2017
Merged
Fix ExtEventLoop to keep track of stream resources (refcount)#123jsor merged 2 commits intoreactphp:masterfrom
jsor merged 2 commits intoreactphp:masterfrom
Conversation
Member
Author
|
Removed the WIP marker as this PR now contains a minimal work around and we can no longer reproduce this issue with this fix applied (see also Travis output) |
WyriHaximus
approved these changes
Dec 1, 2017
andig
reviewed
Dec 1, 2017
| } | ||
|
|
||
| /** | ||
| * Telper for above test. This happens in another helper method to verify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has come to our attention that certain loop implementations do not keep track of assigned stream resources (refcount). This means that stream resources may be garbage collected despite being added to the loop when leaving the scope where they have been defined. Arguably, this is a design decision that makes sense for a number of PHP extension modules.
This issue is implicitly avoiding by using react/stream, which stores the stream resource in a member variable and thus prevents garbage collection. This means that this is not an issue for most people that rely on this component. However, this issue can be exhibited quite easily by using the EventLoop directly.
Given that our loop interface tries to abstract these underlying differences, we may have to keep track of stream resources within our loop abstractions.